-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix publicPath to be windows compatible #366
Conversation
@michael-ciniawsky This actually doesn't fix the issue for me on windows, but I think something like this might: webpackOptions.output.publicPath = path.join('absolute', os.tmpdir(), '_karma_webpack_', publicPath, '/'); |
@chriscasola how does your version with 'absolute' joined on the path fix things? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please undo the changes in files other than src/karma-webpack.js
.
The actual change looks good to me.
@chriscasola can you confirm if this change/your change works on Windows (I'm unable to test), if so I agree with @matthieu-foucault |
I don't understand @chriscasola 's version. |
Closing in favor of #373 |
This PR contains a:
Motivation / Use-Case
When requiring html templates that were loaded with html-loader and then file-loader, the url that was generated was not compatible with windows machines. The path.join was changing the '/' into a ''.
Breaking Changes
N/A
Additional Info