-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for webpack@2.1.0-beta #128
Conversation
LGTM. @sokra would be nice to merge this and publish |
Yes please - would love to get this merged in! |
I need this too +1 |
This is our last blocker to moving to webpack 2.0Beta. Can we assist in anyway? |
I've been temporarily using: |
Thanks @goldhand. I've actually got our setup working with webpack@2.1.0beta15 and karma-webpack@1.7.0. Our tests and setup are simple so maybe partial support is there. I'd need to look into what the issues were in #117 and the changes in this pull request. UPDATE: the peer dependence is just an npm warning, I think as we setup both entry and plugins and pass that through to karma inside karma.conf.js that we are able to not have any issues. Though I agree it's best to officially support webpack@2 :-) |
Peer dependency issues actually prevent |
@jakemhiller acknowledged. I'm now hitting other issues of dependency versions on other packages. I think I'm going to end up having to fork a few packages and install them from our git. Maybe that would work for you? |
yep, that's what i'm doing as a temporary solution, thanks. |
@goldhand - Can we get this updated to v2.1.0-beta.20 ( or as close as is possible to keep the change benign ) and well get this landed assuming nothing starts on fire :) And I agree with @dignifiedquire - This should not require a beta tag on release unless of course @MikaAK would like to start that process as a security blanket. |
LGTM we can merge this into master once it's updated to beta.20 |
Actually, checking semver.npmjs.com, you'll see that |
Fixes the error that webpack 2.1.0-beta.7 will throw if not entry or plugins are specified in options. Update peer dependencies for webpack@2.1.0-beta.X
@MikaAK Updated and tested with beta.20 travis-ci failed but I think that's because it's not set up yet |
FWIW LGTM :-) |
@goldhand - Yes, it's trying to go it's ruby route because there is no Also LGTM :) |
Could someone please publish this change? |
The someone you are looking for would be @MikaAK :) |
Arggg can't edit on this app. @kentcdodds I'll see to getting this published today. At minimum on a next or beta tag. |
Ping again...? |
Waiting of #163 and then a release will be cut |
Sorry @kentcdodds you're waiting on me :( I'll have it fixed momentarily. |
Will fix error thrown by webpack 2.1.0-beta.7+ and support through beta-15 (latest). Resolves #117