Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Ensure the article appears exactly as it will when published #1102 #1153
feat: Ensure the article appears exactly as it will when published #1102 #1153
Changes from 6 commits
a059d85
560a7f7
42cd56d
402bfd2
417cb27
753bc7f
37a91d2
917d78e
516e714
b174cf9
e6dc4c5
c548efd
2fc7387
0a49461
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM: Improved content type detection and rendering
The new logic effectively detects and renders both Tiptap and Markdoc content, aligning with the PR objectives.
Remove the unnecessary type assertion in the Markdoc rendering path:
This change eliminates the incorrect casting of a React element to string, improving type safety.
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the type assertion because
renderedContent
needs to be treated as a string for use indangerouslySetInnerHTML
, and removing it could lead to runtime issues.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dineshsutihar, understood. Thanks for the clarification. Keeping the type assertion ensures correct behavior when using
dangerouslySetInnerHTML
.🐰🤔
✏️ Learnings added