Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mobile safari and desktop chrome to playwright test browsers #1133

Conversation

JohnAllenTech
Copy link
Contributor

✨ Codu Pull Request 💻

Improves E2E testing overall. There are dozens of poor unfortunate souls using mobile safari. We should do everything we can to help their struggle.

Pull Request details

  • Added mobile safari as a test platform
  • Added desktop firefox as a test platform

Any Breaking changes

  • None

Associated Screenshots

image

@JohnAllenTech JohnAllenTech requested a review from a team as a code owner October 15, 2024 21:16
Copy link

vercel bot commented Oct 15, 2024

@JohnAllenTech is attempting to deploy a commit to the Codú Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Oct 15, 2024

Walkthrough

The changes in this pull request focus on updating the playwright.config.ts file for Playwright testing configurations. A new project configuration for Firefox has been added, and the existing configuration for Mobile Chrome has been modified to use a different device. Additionally, a new configuration for Mobile Safari has been introduced. Commented-out sections for other browsers have been removed to streamline the configuration.

Changes

File Change Summary
playwright.config.ts - Added project for Firefox using "Desktop Firefox" with storageState.
- Modified Mobile Chrome project to use "Pixel 9" instead of "iPhone 15".
- Added project for Mobile Safari using "iPhone 16" with storageState.
- Removed commented-out sections for other browsers and mobile devices.

Possibly related PRs

  • feat: init e2e workflow setup #1086: Modifications to playwright.config.ts for local development server commands and commenting out the "Mobile Chrome" project entry are related to the updates in this PR.
  • Feat/improving existing e2e tests #1125: Changes in e2e/home.spec.ts to rename and restructure test cases align with the updates for different device configurations in Playwright testing.

Suggested reviewers

  • NiallJoeMaher

🐇 In the meadow, swift and spry,
New tests for Firefox soar high.
Mobile Safari joins the fun,
With Pixel 9, our work is done!
Configs streamlined, all set to play,
In the world of testing, hip-hip-hooray! 🌼


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between f663233 and b38f212.

📒 Files selected for processing (1)
  • playwright.config.ts (1 hunks)
🧰 Additional context used
🔇 Additional comments (2)
playwright.config.ts (2)

62-68: LGTM: Mobile Safari configuration added successfully.

The new Mobile Safari configuration aligns perfectly with the PR objectives. It uses the "iPhone 16" device, which is a good choice for testing the latest iOS version. The storageState path and dependency on the "setup" project are correctly configured.


46-53: LGTM: Firefox configuration added successfully.

The new Firefox configuration aligns with the PR objectives and follows the correct structure. It uses the "Desktop Firefox" device and includes the necessary storageState path for consistent authentication.

Let's verify the existence of the "setup" project:

✅ Verification successful

Verified: "setup" project exists in configuration.

The "setup" project is correctly defined in playwright.config.ts, ensuring proper initialization and dependency management.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the existence of the "setup" project in the configuration.

# Test: Search for the "setup" project definition. Expect: At least one match.
rg --type typescript 'name:\s*"setup"' playwright.config.ts

Length of output: 96


Script:

#!/bin/bash
# Description: Verify the existence of the "setup" project in the configuration without specifying file type.

# Test: Search for the "setup" project definition. Expect: At least one match.
rg 'name:\s*"setup"' playwright.config.ts

Length of output: 95


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
codu ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 3:08pm

Copy link
Contributor

@NiallJoeMaher NiallJoeMaher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🦖

@NiallJoeMaher
Copy link
Contributor

Getting some errors in the playwright runner around bookmarks and algolia. Nice and strange 🤔

@NiallJoeMaher NiallJoeMaher merged commit 4c064e9 into codu-code:develop Oct 16, 2024
6 checks passed
@JohnAllenTech
Copy link
Contributor Author

Getting some errors in the playwright runner around bookmarks and algolia. Nice and strange 🤔

Yeah I saw that. My guess was the mybookmarks endpoint is being called even if a user isnt logged in. Ill take a quick look tonight

@JohnAllenTech
Copy link
Contributor Author

JohnAllenTech commented Oct 16, 2024

Created n issue for it #1138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants