-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve #194 -- Add support to run Pictures for a image CDN #195
Conversation
af06078
to
789b773
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #195 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 489 496 +7
=========================================
+ Hits 489 496 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
789b773
to
e025438
Compare
e025438
to
f30265e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codingjoe
I cannot really tell how the changes allow hosting on a CDN. I'll need to trust you on this.
Nevertheless, I left you some comments targeted at documentation.
Add support documented support to run an external image processor like Cloudinary or AWS lambda.
This does not remove the need to have Pillow installed, as Django requires Pillow to read the image dimensions.