Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #194 -- Add support to run Pictures for a image CDN #195

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

codingjoe
Copy link
Owner

@codingjoe codingjoe commented Dec 15, 2024

Add support documented support to run an external image processor like Cloudinary or AWS lambda.

This does not remove the need to have Pillow installed, as Django requires Pillow to read the image dimensions.

@codingjoe codingjoe self-assigned this Dec 15, 2024
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9ebc0f6) to head (8573caa).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #195   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          489       496    +7     
=========================================
+ Hits           489       496    +7     
Flag Coverage Δ
celery 85.08% <89.47%> (+0.21%) ⬆️
cleanup 88.50% <89.47%> (+0.16%) ⬆️
dj4.1 88.50% <89.47%> (+0.16%) ⬆️
dj4.2 88.50% <89.47%> (+0.16%) ⬆️
django-rq 85.08% <89.47%> (+0.21%) ⬆️
dramatiq 85.08% <89.47%> (+0.21%) ⬆️
drf 96.37% <100.00%> (+0.05%) ⬆️
macos-latest 88.70% <89.47%> (+0.16%) ⬆️
py3.10 88.50% <89.47%> (+0.16%) ⬆️
py3.12 88.50% <89.47%> (+0.16%) ⬆️
py3.8 88.50% <89.47%> (+0.16%) ⬆️
py3.9 88.50% <89.47%> (+0.16%) ⬆️
ubuntu-latest 88.50% <89.47%> (+0.16%) ⬆️
windows-latest 81.76% <33.33%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@herrbenesch herrbenesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codingjoe
I cannot really tell how the changes allow hosting on a CDN. I'll need to trust you on this.
Nevertheless, I left you some comments targeted at documentation.

pictures/models.py Outdated Show resolved Hide resolved
pictures/models.py Outdated Show resolved Hide resolved
pictures/tasks.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@codingjoe codingjoe merged commit 9aaa603 into main Dec 17, 2024
23 checks passed
@codingjoe codingjoe deleted the issues/194/cdn branch December 17, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants