-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #176 -- Allow overriding the img-tag dimensions attributes #177
Fix #176 -- Allow overriding the img-tag dimensions attributes #177
Conversation
Please let me know if you need help with the tests. I believe it's only the attribute order that changed, should be pretty straightforward. However, I would appreciate it if you could add a new test to prevent regression. |
Thank you very much for your support and advice! I added a test to check new attributes and also fixed I hope, everything will be okay in CI this time. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 486 486
=========================================
Hits 486 486
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @atnartur, I took the liberty to amend some changes, like dropping a leftover print statement.
However, I want to not, that I also reverted your changes to the alt
-attribute. Please beware that setting an alt
attribute is required. There are cases, where an empty string is the best way to go, but that would be a matter for a separate patch.
Closes #176