Added Bucket Sort #300
Merged
Added Bucket Sort #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #300 +/- ##
=============================================
+ Coverage 98.827% 98.845% +0.017%
=============================================
Files 25 25
Lines 2901 2944 +43
=============================================
+ Hits 2867 2910 +43
Misses 34 34
|
czgdp1807
reviewed
Sep 29, 2020
Comment on lines
495
to
498
| ''' | ||
| Find maximum value in the list and use length of the list to determine which value in the list | ||
| goes into which bucket | ||
| ''' |
There was a problem hiding this comment.
Suggested change
| ''' | |
| Find maximum value in the list and use length of the list to determine which value in the list | |
| goes into which bucket | |
| ''' | |
| # Find maximum value in the list and use length of the list to determine which value in the list goes into which bucket |
czgdp1807
reviewed
Sep 29, 2020
| max_value = array[i] | ||
|
|
||
|
|
||
| size = max_value / count |
There was a problem hiding this comment.
Suggested change
| size = max_value / count | |
| size = max_value // count |
czgdp1807
reviewed
Sep 29, 2020
| # Put list elements into different buckets based on the size | ||
| for i in range(len(array)): | ||
| if array[i] is not None: | ||
| j = int(array[i] / size) |
There was a problem hiding this comment.
Suggested change
| j = int(array[i] / size) | |
| j = array[i] // size |
czgdp1807
reviewed
Sep 29, 2020
| if j is not count: | ||
| buckets_list[j].append(array[i]) | ||
| else: | ||
| buckets_list[count - 1].append(array[i]) |
There was a problem hiding this comment.
Suggested change
| buckets_list[count - 1].append(array[i]) | |
| buckets_list[count-1].append(array[i]) |
czgdp1807
reviewed
Sep 29, 2020
| final_output = [] | ||
| for x in range(count): | ||
| final_output = final_output + buckets_list[x] | ||
| final_output = DynamicOneDimensionalArray(int, final_output) |
There was a problem hiding this comment.
I think the return type of final_output should be same as array i.e., type(array) == type(final_output) should be True.
There was a problem hiding this comment.
Do you think this would be correct here? final_output = type(array)(int, final_output)
There was a problem hiding this comment.
Is it possible to sort the array in-place using bucket sort algorithm? Please do so if that's possible.
There was a problem hiding this comment.
I think, Bucketsort cannot be implemented in-place. This is because the buckets should be of variable sizes and these sizes cannot be known priorly.
czgdp1807
reviewed
Sep 29, 2020
Comment on lines
93
to
106
|
|
||
| def test_bucket_sort(): | ||
| random.seed(1000) | ||
|
|
||
| n = random.randint(10, 20) | ||
| arr = DynamicOneDimensionalArray(int, 0) | ||
| for _ in range(n): | ||
| arr.append(random.randint(1, 1000)) | ||
| for _ in range(n // 3): | ||
| arr.delete(random.randint(0, n // 2)) | ||
|
|
||
| expected_arr = [102, 134, 228, 247, 362, 373, 448, | ||
| 480, 548, 686, 688, 696, 779] | ||
| assert bucket_sort(arr)._data == expected_arr |
There was a problem hiding this comment.
Suggested change
| def test_bucket_sort(): | |
| random.seed(1000) | |
| n = random.randint(10, 20) | |
| arr = DynamicOneDimensionalArray(int, 0) | |
| for _ in range(n): | |
| arr.append(random.randint(1, 1000)) | |
| for _ in range(n // 3): | |
| arr.delete(random.randint(0, n // 2)) | |
| expected_arr = [102, 134, 228, 247, 362, 373, 448, | |
| 480, 548, 686, 688, 696, 779] | |
| assert bucket_sort(arr)._data == expected_arr |
There was a problem hiding this comment.
Instead of the above add one line below the following,
def test_bucket_sort():
_test_common_sort(bucket_sort)
czgdp1807
reviewed
Sep 30, 2020
czgdp1807
reviewed
Sep 30, 2020
czgdp1807
reviewed
Sep 30, 2020
czgdp1807
reviewed
Sep 30, 2020
czgdp1807
reviewed
Sep 30, 2020
czgdp1807
reviewed
Sep 30, 2020
czgdp1807
reviewed
Sep 30, 2020
czgdp1807
reviewed
Sep 30, 2020
czgdp1807
reviewed
Sep 30, 2020
|
Thanks for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References to other Issues or PRs or Relevant literature
Fixes #291
Brief description of what is fixed or changed
Bucket Sort is added with the buckets sorter as insertion sort