This repository was archived by the owner on Oct 2, 2018. It is now read-only.
Add margin indicators #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the minimalism of these indicators 👍! The indicators remain at the bottom of the screen in documents that are smaller than the editor (because of the edit DIV's fixed height). Is this trivial enough to overlook? |
|
That would indeed be better, not super easy though. I'll try fixing it later. |
|
Here you go. This commit probably deserves testing on a multitude of browsers and documents, including new and empty ones, if you can. |
|
The patch functions well on:
|
|
Alright, great. Do you want me to merge? |
|
Sure! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #201 and #205 I've been talking about some sort of border, but I thought this looked better.