Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make click event of block propagate #1020

Closed
wants to merge 1 commit into from
Closed

Make click event of block propagate #1020

wants to merge 1 commit into from

Conversation

hata6502
Copy link
Contributor

@hata6502 hata6502 commented Jan 24, 2020

@hata6502 hata6502 changed the title Bugfix/propagate click event Make click event of block propagate Jan 24, 2020
@neSpecc
Copy link
Member

neSpecc commented Jan 24, 2020

Thanks for the PR. Please, attach an issue that describes a problem you resolve.

@natterstefan
Copy link
Contributor

Is this also related to #946 @hata6502?

@hata6502
Copy link
Contributor Author

Yes, I also use React.

@ryandunnewold
Copy link

ryandunnewold commented Feb 25, 2020

Running into this issue as well. Any updates here?

Update:

Tested this locally and seems like it breaks the toolbar UI

@dyrdzik
Copy link

dyrdzik commented Feb 26, 2020

The same problem on our end. We've also discovered that usually (which looks weird) buttons fire events. When having select element it does not go through. Only when you double click in block area as it makes window.getSelection().isCollapsed return false.

@2277Dhruv
Copy link

Running into this issue as well. Are there any updates?!

@hata6502
Copy link
Contributor Author

Very sorry that I didn't update this PR.
I seem this issue doesn't cause with Vanilla JS.
So, I think it is not a bug in Editor JS.

Demo
Listen click event correctly.
https://codesandbox.io/s/editor-js-propagate-click-events-w5371?fontsize=14&hidenavigation=1&theme=dark

@allankikkas
Copy link

#1051 (comment)

@hata6502 hata6502 deleted the bugfix/propagate-click-event branch March 28, 2020 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants