Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade discord.js version to support new username system #88

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

Madjosz
Copy link
Contributor

@Madjosz Madjosz commented Aug 23, 2023

  • upgrade discord.js to v14.12
  • extend /info user to test and show new fields
  • upgrade minimum node version to v16.9
  • upgrade TS target to es2020

package.json Show resolved Hide resolved
"@types/ws": "^8.5.5",
"husky": "^8.0.3",
"jest": "^29.6.2",
"plop": "^3.1.2",
"prettier": "^2.3.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier cannot be updated to latest v3 because of prettier/eslint-plugin-prettier#562

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we only upgrade packages related to discord.js for now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I tried this first but it threw me into dependency hell and I got a whole lot of version conflicts and compiler errors. I can take a look at it tomorrow again.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following necessary dependency upgrades:

  • discord.js 14.12 needs typescript 5.1.6
  • ts-jest 27.0.3 needs typescript < 5.0 => upgrade to 28.0.0
  • ts-jest 28.0.0 needs jest 28.0.0

tsconfig.json Show resolved Hide resolved
* upgrade discord.js to v14.12
* extend /info user to test and show new fields
* upgrade minimum node version to v16.9
* upgrade TS target to es2020
@kazk kazk merged commit b986cde into codewars:main Aug 29, 2023
1 check passed
@Madjosz Madjosz deleted the upgrade_discordjs branch September 28, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants