-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add entries in to rare dictionary #2421
base: main
Are you sure you want to change the base?
Conversation
@@ -190,6 +193,7 @@ wee->we | |||
whats->what's | |||
whet->when, what, wet, | |||
whiling->while | |||
whit->with, white, wit, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested word wit
for whit->with, white, wit,
has a misspell entry wit->with
in the rare dictionary. This causes the checks to fail. You might want to change to whit->with, white,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I think it's a valid suggestion, it's just like some others where we need to deal with these circular edge cases, probably by updating our check config...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luzpaz Perhaps the suggestion to remove whit->with, white, wit,
from this merge request and create a specific one for that case is preferable, isn't it?
Split off from codespell-project#2266
3e91c5e
to
39de76c
Compare
Split off from #2266