Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entries in to rare dictionary #2421

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

luzpaz
Copy link
Collaborator

@luzpaz luzpaz commented Jul 29, 2022

Split off from #2266

@@ -190,6 +193,7 @@ wee->we
whats->what's
whet->when, what, wet,
whiling->while
whit->with, white, wit,
Copy link
Contributor

@vikivivi vikivivi Jul 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested word wit for whit->with, white, wit, has a misspell entry wit->with in the rare dictionary. This causes the checks to fail. You might want to change to whit->with, white,

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I think it's a valid suggestion, it's just like some others where we need to deal with these circular edge cases, probably by updating our check config...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luzpaz do you want to do a new PR with the other suggestions just leaving this one separately as one for us to address later?

Or even with @vikivivi 's shorter suggested list. But I'd like to get whit->wit in ultimately as a suggestion too.

Copy link
Collaborator

@DimitriPapadopoulos DimitriPapadopoulos Jul 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luzpaz Perhaps the suggestion to remove whit->with, white, wit, from this merge request and create a specific one for that case is preferable, isn't it?

@peternewman peternewman added the dictionary Changes to the dictionary label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dictionary Changes to the dictionary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants