Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider reverting lien->line #3630

Open
rjmoseley opened this issue Feb 3, 2025 · 4 comments · May be fixed by #3631
Open

Consider reverting lien->line #3630

rjmoseley opened this issue Feb 3, 2025 · 4 comments · May be fixed by #3631
Labels
dictionary Changes to the dictionary

Comments

@rjmoseley
Copy link

#3460 added a lien->line typo, but lien is a valid word - definition.

In our case it is used fairly commonly within our terraform code in relation to the google_resource_manager_lien resource. This resource configured a lien within Google Cloud Platform which prevents the deletion of a project or resource.

It's used within multiple repos and whilst I could add ignored words everywhere, lien is a dictionary word and we won't be the only people using the google_resource_manager_lien resource in terraform.

nikolaik added a commit to nikolaik/codespell that referenced this issue Feb 3, 2025
Since `lien` is a word frequently used when working with the Google
Terraform Provider, it feels wrong to treat it as a typo.

Humbly suggesting to revert that change

This reverts commit 536ccb5.

Fixes codespell-project#3630
@nikolaik nikolaik linked a pull request Feb 3, 2025 that will close this issue
@DimitriPapadopoulos DimitriPapadopoulos added the dictionary Changes to the dictionary label Feb 3, 2025
@DimitriPapadopoulos
Copy link
Collaborator

Note that this typo is in the rare dictionary. Perhaps the rare dictionary should not be selected by default.

@DimitriPapadopoulos
Copy link
Collaborator

DimitriPapadopoulos commented Feb 3, 2025

#3460 added a lien->line typo, but lien is a valid word - definition.

https://www.google.com/search?q=define+lien is not a valid link in an international context. Besides, we usually refer to curated dictionaries only, such as the OED.

@rjmoseley
Copy link
Author

Happy to provide a OED link as well - https://www.oed.com/search/dictionary/?scope=Entries&q=lien

@TheGiraffe3
Copy link
Contributor

nikolaik added a commit to nikolaik/codespell that referenced this issue Feb 5, 2025
nikolaik added a commit to nikolaik/codespell that referenced this issue Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dictionary Changes to the dictionary
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants