Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use fork of astring and update meriyah #6173

Closed
wants to merge 11 commits into from

Conversation

DeMoorJasper
Copy link
Member

@DeMoorJasper DeMoorJasper commented Sep 30, 2021

What kind of change does this PR introduce?

Uses a more thoroughly tested fork of astring and updates meriyah as there's been a bunch of changes since 1.9.7

Still gotta do some work in the esmodule convert module as there's been some changes in the spec there... also messed up something in the printer as it now prints a lot bit too much brackets, some more testing and finetuning should resolve that

https://github.com/DeMoorJasper/meriyah-printer

Closes CSB-1304
Closes #6160

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 30, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ab82d93:

Sandbox Source
Notifications Test Configuration
wana deferred update (forked) Issue #6160

@lbogdan lbogdan temporarily deployed to pr6173 September 30, 2021 18:47 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Sep 30, 2021

Build for latest commit ab82d93 is at https://pr6173.build.csb.dev/s/new.

@DeMoorJasper DeMoorJasper marked this pull request as ready for review October 1, 2021 08:16
@linear
Copy link

linear bot commented Oct 1, 2021

CSB-1304 Fix issues with astring printer

Fork astring and make it more maintainable and add support for all missing meriyah nodes and improve the test suite.

We rely on this printer so it should be reliable. If we make this super-reliable we might even be able to replace babel for 90% of code we transpile improving our performance A LOT

#6160

@lbogdan lbogdan temporarily deployed to pr6173 October 1, 2021 08:24 Inactive
@lbogdan lbogdan temporarily deployed to pr6173 October 1, 2021 08:48 Inactive
@DeMoorJasper
Copy link
Member Author

Gonna move this back to draft as this sandbox (https://codesandbox.io/s/prod-pine-u8og2?file=/src/App.jsx) is failing...

@DeMoorJasper DeMoorJasper marked this pull request as draft October 1, 2021 17:07
@lbogdan lbogdan temporarily deployed to pr6173 October 8, 2021 18:34 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transpiled ESM dependency is referencing CJS packages incorrectly
2 participants