-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use fork of astring and update meriyah #6173
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ab82d93:
|
Build for latest commit ab82d93 is at https://pr6173.build.csb.dev/s/new. |
CSB-1304 Fix issues with astring printer
Fork astring and make it more maintainable and add support for all missing meriyah nodes and improve the test suite. We rely on this printer so it should be reliable. If we make this super-reliable we might even be able to replace babel for 90% of code we transpile improving our performance A LOT |
Gonna move this back to draft as this sandbox (https://codesandbox.io/s/prod-pine-u8og2?file=/src/App.jsx) is failing... |
What kind of change does this PR introduce?
Uses a more thoroughly tested fork of astring and updates meriyah as there's been a bunch of changes since
1.9.7
Still gotta do some work in the esmodule convert module as there's been some changes in the spec there... also messed up something in the printer as it now prints a lot bit too much brackets, some more testing and finetuning should resolve that
https://github.com/DeMoorJasper/meriyah-printer
Closes CSB-1304
Closes #6160