Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow deleting templates/sandboxes linked to a GitHub repo #6081

Closed
wants to merge 1 commit into from

Conversation

smhutch
Copy link
Contributor

@smhutch smhutch commented Aug 30, 2021

WIP

  • Fix styling rough edges
  • Add delete function to context menu on dashboard

Review this condition:

// TODO(@CompuIves): remove the `item.sandbox.teamId === null` check, once the server is not
// responding with teamId == null for personal templates anymore.

@smhutch smhutch changed the title fix: allow deleting templates fix: allow deleting templates/sandboxes linked to a GitHub repo Aug 30, 2021
@smhutch
Copy link
Contributor Author

smhutch commented Aug 30, 2021

@CompuIves I started looking into this today, and found your code comment from a year ago that feels related 😄
Do you think we can remove that condition now and show the option to delete templates / sandboxes that are linked to GH from the dashboard ContextMenu?

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5be01e1:

Sandbox Source
Notifications Test Configuration

@lbogdan
Copy link
Contributor

lbogdan commented Aug 30, 2021

Build for latest commit 5be01e1 is at https://pr6081.build.csb.dev/s/new.

@smhutch smhutch closed this Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants