extend socket jwt ttl timeout #6028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent db outage on deploy we're extending the socket jwt ttl on the server side, but we need to also extend how long we cache it on the frontend, or that is pointless.
sannek
force-pushed
the
fix/extend_socket_jwt_ttl
branch
from
1dc0156 to
b50ac39
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b50ac39:
|
|
Build for latest commit b50ac39 is at https://pr6028.build.csb.dev/s/new. |
CompuIves
approved these changes
Aug 9, 2021
This was referenced Oct 27, 2023
This was referenced Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve server deploys, we're extending the socket jwt ttl on the server side, but
we need to also extend how long we cache it on the frontend, or all this is pointless.
[Note: requires the server changes to be deployed first!!]
What kind of change does this PR introduce?
Extend how long we cache JWTs for to improve server deploys
What is the current behavior?
Everyone reconnects at the same time and the DB doesn't like that
What is the new behavior?
What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
Checklist