217 fix super stream consumer property #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thanks for your PR. |
|
@tunniclm Thank you. |
tarzacodes
reviewed
Dec 17, 2024
tarzacodes
reviewed
Dec 17, 2024
|
Brilliant, very good work and thanks! Added just a very minor comment, but everything else looks spiffy and clean ✨ |
|
LGTM for me, just needs a rebase! I haven't worked on this project for a minute now so maybe a second pair of eyes might be ideal. |
added 2 commits
December 19, 2024 18:56
When a stream consumer attaches to a stream that is part of a super stream it should set the "super-stream" property to the name of the super stream in order to ensure the partition index will be setup enabling the consumers to be balanced and rebalanced across the partitions.
tunniclm
force-pushed
the
217-fix-super-stream-consumer-property
branch
from
94fbc3c to
84725e9
Compare
|
Rebased on latest |
|
@tunniclm the merge has been blocked due to the CI failing, can you fix that? |
Goodness, I didn't notice that - sorry! |
dc1992
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #217
The active part of the change is adding the property to the consumer:
https://github.com/coders51/rabbitmq-stream-js-client/pull/218/files#diff-25d66d74617fe2e23d7946bd6e3ba95640ab1b9bc8947445d604fc271c7c1f12R490-R492
The rest is plumbing to get the super stream name passed down to the right place.
I have added a test which fails on
mainand passes on this branch. I have included it inside the existing super stream consumer end-to-end test.I'd be happy to work through any comments or suggested restructures in order to get this in shape to be merged.
Thanks