Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] creation of stream with arguments #176

Merged
merged 4 commits into from
Feb 1, 2024

Conversation

l4mby
Copy link
Contributor

@l4mby l4mby commented Jan 30, 2024

Creation stream arguments were ignored because the property key started with x-.
Moreover the queue-leader-locator argument can take up to 3 values which are random, client-local and least-leaders.
Also, the max-age argument is a string of numbers ending with a trailing s

@l4mby l4mby added the bug Something isn't working label Jan 30, 2024
@l4mby l4mby self-assigned this Jan 30, 2024
@l4mby l4mby linked an issue Jan 30, 2024 that may be closed by this pull request
icappello
icappello previously approved these changes Jan 31, 2024
Copy link
Member

@icappello icappello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tarzacodes
tarzacodes previously approved these changes Feb 1, 2024
Copy link
Contributor

@tarzacodes tarzacodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for me as well!

@l4mby l4mby force-pushed the 174-bug-stream-arguments-are-ignored branch from a094b70 to a7615a7 Compare February 1, 2024 13:36
@l4mby l4mby dismissed stale reviews from tarzacodes and icappello via b626506 February 1, 2024 13:44
Copy link
Contributor

@tarzacodes tarzacodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again

@l4mby l4mby merged commit 74fcb86 into main Feb 1, 2024
1 check passed
@l4mby l4mby deleted the 174-bug-stream-arguments-are-ignored branch February 1, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Stream arguments are ignored when creating a new stream
3 participants