-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
55 ability to consume a batch of messages without compression #113
Merged
albertobarrila
merged 9 commits into
main
from
55-ability-to-consume-a-batch-of-messages-without-compression
Dec 6, 2023
Merged
55 ability to consume a batch of messages without compression #113
albertobarrila
merged 9 commits into
main
from
55-ability-to-consume-a-batch-of-messages-without-compression
Dec 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pipeline is red because of the usual rabbitMQ plugins in pipeline issue. The tests are green if you run them locally |
l4mby
force-pushed
the
55-ability-to-consume-a-batch-of-messages-without-compression
branch
from
December 6, 2023 07:40
70b47d4
to
fb67fdc
Compare
* Add logger configuration * Minor fixes * Try a new version of rabbit * Try the same rabbit version as dotnet * Fix in decode response * Remove winston from deps * Remove async await from createConnection * Revert of undefined check --------- Co-authored-by: magne <magnello@coders51.com>
l4mby
force-pushed
the
55-ability-to-consume-a-batch-of-messages-without-compression
branch
from
December 6, 2023 10:31
ddd9699
to
ccdab17
Compare
albertobarrila
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have fixxed the "wrong" things with @gpad
albertobarrila
deleted the
55-ability-to-consume-a-batch-of-messages-without-compression
branch
December 6, 2023 13:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the issue. We can now read from the batch subentries