KSPACE-46: Use SpaceProvisionerConfig for space placement decisions #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-manager-uses-SPC-2
…functions on the ToolchainConfig in the tests.
enabled and ready states on the cluster selection.
…-manager-uses-SPC-2
metlos
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
This was referenced Mar 14, 2024
… only use them in tests and in places that actually test the deprecated functionality. This will be removed in the future.
…-manager-uses-SPC-2
…PC-2' into KSPACE-5-capacity-manager-uses-SPC-2
* fix some conditions in the tests * small doc updates
…PC-2' into KSPACE-5-capacity-manager-uses-SPC-2
host-operator here and simplify their signatures.
…-manager-uses-SPC-2
….com/metlos/codeready-host-operator into KSPACE-5-capacity-manager-uses-SPC-2
MatousJobanek
approved these changes
Mar 22, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MatousJobanek, metlos The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
….com/metlos/codeready-host-operator into KSPACE-5-capacity-manager-uses-SPC-2
|
|
@metlos Let's wait with the merge till Monday morning, so we have some time to check and monitor that everything is working fine in production. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #991 +/- ##
==========================================
+ Coverage 84.75% 84.87% +0.12%
==========================================
Files 55 55
Lines 5039 5066 +27
==========================================
+ Hits 4271 4300 +29
+ Misses 584 583 -1
+ Partials 184 183 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the logic in
pkg/capacity/manager.goto use the configuration from theSpaceProvisionerConfigobjects instead of the configuration in theToolchainConfig.Note that e2e tests are not passing yet, so this must not be merged atm.
JIRA issue: https://issues.redhat.com/browse/KSPACE-46
Associated PRs in other repos: