Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure connection is closed at all error points #193

Merged
merged 2 commits into from
Feb 21, 2020
Merged

Ensure connection is closed at all error points #193

merged 2 commits into from
Feb 21, 2020

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Feb 20, 2020

Closes #191

@nhooyr
Copy link
Contributor Author

nhooyr commented Feb 20, 2020

cc @coadler

@coadler
Copy link
Contributor

coadler commented Feb 20, 2020

👍 lgtm

@nhooyr
Make writeMu a channel based mutex
2e0dd1c 
Will prevent deadlock if a writer is used after close.
@nhooyr nhooyr merged commit c62c0dc into master Feb 21, 2020
@nhooyr nhooyr deleted the ensure-close branch February 21, 2020 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Seeing failed to get reader and to write msg errors
2 participants
@nhooyr @coadler