-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add action for detecting sub-chart changes #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
378c5ac
to
f4ab3a3
Compare
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
Signed-off-by: Danny Kopping <danny@coder.com>
4511112
to
e8108cd
Compare
johnstcn
reviewed
Jul 22, 2024
Signed-off-by: Danny Kopping <danny@coder.com>
f3d5311
to
5b4c796
Compare
johnstcn
reviewed
Jul 22, 2024
Signed-off-by: Danny Kopping <danny@coder.com>
johnstcn
reviewed
Jul 22, 2024
Signed-off-by: Danny Kopping <danny@coder.com>
johnstcn
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
Could add a check_dependencies
function in lib.sh
but I don't need to review again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until dependabot supports helm charts, we need a way to ensure we're up-to-date with our subcharts' latest versions.
I've added dependency constraints to all the subcharts so that minor & patch releases are accepted.
Additionally, I've added a
make build
target which will update the subcharts and runhelm template
to render the YAML manifests. If there are any changes outside of expected ones (like version/image updates in the manifests themselves), this will create an issue and assign it to me.