Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting priorityClassName via helm chart #5255

Merged
merged 5 commits into from
Jul 18, 2022
Merged

Allow setting priorityClassName via helm chart #5255

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
800123c
Allow setting priorityClassName via helm chart
timbrd Jun 10, 2022
978bc00
Merge branch 'main' into helm-priorityClassName
jsjoeio Jun 10, 2022
2583a95
Merge branch 'main' into helm-priorityClassName
jsjoeio Jun 23, 2022
467437a
Merge branch 'main' into helm-priorityClassName
timbrd Jul 2, 2022
9ff3bf4
Merge branch 'main' into helm-priorityClassName
jsjoeio Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ci/helm-chart/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ spec:
{{- if .Values.hostnameOverride }}
hostname: {{ .Values.hostnameOverride }}
{{- end }}
{{- if .Values.priorityClassName }}
priorityClassName: {{ .Values.priorityClassName }}
{{- end }}
{{- if .Values.securityContext.enabled }}
securityContext:
fsGroup: {{ .Values.securityContext.fsGroup }}
Expand Down
2 changes: 2 additions & 0 deletions ci/helm-chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ podAnnotations: {}
podSecurityContext: {}
# fsGroup: 2000

priorityClassName: ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The if statement which evaluates if this is populated or not in deployment.yaml will evaluate to true and populate this invalid null string by default won't it?

Should this be commented out by default?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind docs say empty strings evaluate false.

https://helm.sh/docs/chart_template_guide/control_structures/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL! So do you think this is good to merge?


service:
type: ClusterIP
port: 8080
Expand Down