Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support git-lfs default #4611

Merged
merged 2 commits into from
Dec 14, 2021
Merged

support git-lfs default #4611

merged 2 commits into from
Dec 14, 2021

Conversation

huangyoukun
Copy link
Contributor

support git-lfs default

@huangyoukun huangyoukun requested a review from a team as a code owner December 12, 2021 02:56
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding this is reasonable, @jsjoeio thoughts?

@jsjoeio
Copy link
Contributor

jsjoeio commented Dec 13, 2021

I think adding this is reasonable, @jsjoeio thoughts?

Agreed! I don't see any downsides.

@jsjoeio jsjoeio self-assigned this Dec 13, 2021
@jsjoeio jsjoeio added this to the 4.0.1 milestone Dec 13, 2021
@jsjoeio
Copy link
Contributor

jsjoeio commented Dec 13, 2021

I'll merge when the rest is passing (ignore Docs preview)

@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #4611 (71bf501) into main (18e66c4) will not change coverage.
The diff coverage is n/a.

❗ Current head 71bf501 differs from pull request most recent head 90b08de. Consider uploading reports for the commit 90b08de to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4611   +/-   ##
=======================================
  Coverage   66.14%   66.14%           
=======================================
  Files          30       30           
  Lines        1654     1654           
  Branches      331      331           
=======================================
  Hits         1094     1094           
  Misses        475      475           
  Partials       85       85           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18e66c4...90b08de. Read the comment docs.

@jsjoeio jsjoeio modified the milestones: 4.0.1, 4.0.0 Dec 13, 2021
@jsjoeio jsjoeio merged commit 5960a67 into coder:main Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants