Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace eslint-import-resolver-alias with resolver-typescript #4546

Merged
merged 3 commits into from
Dec 7, 2021
Merged

chore: replace eslint-import-resolver-alias with resolver-typescript #4546

merged 3 commits into from
Dec 7, 2021

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Nov 24, 2021

As title

@JounQin JounQin requested a review from a team as a code owner November 24, 2021 05:17
@JounQin
Copy link
Contributor Author

JounQin commented Nov 25, 2021

cc @jsjoeio

@jsjoeio jsjoeio self-assigned this Nov 29, 2021
@jsjoeio jsjoeio added the chore Related to maintenance or clean up label Nov 29, 2021
@jsjoeio
Copy link
Contributor

jsjoeio commented Nov 29, 2021

Hi @JounQin - thank you for submitting this PR! Can you explain why you've opened this PR and what this fixes or what benefits this brings? I'm not familiar with resolver-typescript

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #4546 (74ebe76) into main (d15731a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4546   +/-   ##
=======================================
  Coverage   65.52%   65.52%           
=======================================
  Files          30       30           
  Lines        1665     1665           
  Branches      334      334           
=======================================
  Hits         1091     1091           
  Misses        485      485           
  Partials       89       89           
Impacted Files Coverage Δ
src/node/wsRouter.ts 91.66% <ø> (ø)
src/node/http.ts 55.68% <100.00%> (ø)
src/node/routes/pathProxy.ts 69.23% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d15731a...74ebe76. Read the comment docs.

@JounQin
Copy link
Contributor Author

JounQin commented Nov 29, 2021

@jsjoeio As you can see at https://github.com/cdr/code-server/pull/4546/files#diff-3894e4104cda190617684d0dc5d55e39e49c63cc6955edf4a446b91ae086bbd2, eslint-import-resolver-typescript resolves .ts/.tsx/.d.ts and @types/* packages correctly and there is no need to ignore "unresolved" errors anymore.

@jsjoeio
Copy link
Contributor

jsjoeio commented Nov 30, 2021

Ahh! (That code was before me)

Now I see. Thanks for fixing/replacing this! You can ignore the Docs preview but as long as the rest of CI passes (it should), we can merge!

Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for doing this!

@JounQin
Copy link
Contributor Author

JounQin commented Dec 3, 2021

@jsjoeio Shall we merge then?

@jsjoeio
Copy link
Contributor

jsjoeio commented Dec 6, 2021

Shall we merge then?

Yes! Apologies I was out Thurs/Fri but should get this in today :D Thanks for the bump!

@jsjoeio jsjoeio merged commit 6c9c840 into coder:main Dec 7, 2021
@JounQin JounQin deleted the chore/eslint-import-resolver-typescript branch December 8, 2021 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to maintenance or clean up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants