-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace eslint-import-resolver-alias with resolver-typescript #4546
chore: replace eslint-import-resolver-alias with resolver-typescript #4546
Conversation
cc @jsjoeio |
Hi @JounQin - thank you for submitting this PR! Can you explain why you've opened this PR and what this fixes or what benefits this brings? I'm not familiar with |
Codecov Report
@@ Coverage Diff @@
## main #4546 +/- ##
=======================================
Coverage 65.52% 65.52%
=======================================
Files 30 30
Lines 1665 1665
Branches 334 334
=======================================
Hits 1091 1091
Misses 485 485
Partials 89 89
Continue to review full report at Codecov.
|
@jsjoeio As you can see at https://github.com/cdr/code-server/pull/4546/files#diff-3894e4104cda190617684d0dc5d55e39e49c63cc6955edf4a446b91ae086bbd2, eslint-import-resolver-typescript resolves |
Ahh! (That code was before me) Now I see. Thanks for fixing/replacing this! You can ignore the Docs preview but as long as the rest of CI passes (it should), we can merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for doing this!
@jsjoeio Shall we merge then? |
Yes! Apologies I was out Thurs/Fri but should get this in today :D Thanks for the bump! |
As title