Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update VS Code to 1.33.0 #445

Merged
merged 9 commits into from
Apr 5, 2019
Merged

Update VS Code to 1.33.0 #445

merged 9 commits into from
Apr 5, 2019

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented Apr 5, 2019 •
edited
Loading

  • Apply patch to new version
  • Check for new changes that need patching (mainly browser/platform-related changes)
  • Context menus, title bar, title bar menus, dialogs on all client platforms, keybindings
  • Ensure services work
    • Extension host
    • Shared process
    • Watcher
    • Searcher
  • Welcome page
  • Readmes & update notes
  • Ensure general file functionality works
    • Editing
    • Saving
    • Creating
    • Deleting
  • Debugging
  • Terminal
  • Auto-recovery (except shared process which should show a message)
  • Fix really slow file tree due to VS Code performing lstat calls one at a time
  • Drag and drop

@code-asher code-asher marked this pull request as ready for review April 5, 2019 22:11
@code-asher code-asher requested a review from kylecarbs as a code owner April 5, 2019 22:11
@code-asher code-asher merged commit a1136b3 into master Apr 5, 2019
@code-asher code-asher deleted the feature/1.33.0 branch April 5, 2019 23:49
andreimc added a commit to devonlineco/code-server that referenced this pull request Apr 7, 2019
@andreimc
Merge remote-tracking branch 'upstream/master'
97c73e6 
* upstream/master:
  Update VS Code to 1.33.0 (coder#445)
  Reduce layers in Dockerfile
  Update README.md
  Significantly improve the Dockerfile
  Use an init system
  fix: slap adduser into another RUN
  feat: user-mode docker
  Fix sending dates through the protocol
  Remove non-working menu items
  Update @coder/nbin. Fixes UI state saves
  Build for production in Docker
  Update @coder/nbin
@nol166
Copy link
Contributor

nol166 commented Apr 11, 2019 •
edited
Loading

Looks like they just updated to 1.33.1
https://github.com/Microsoft/vscode/milestone/94?closed=1

@code-asher code-asher mentioned this pull request Apr 25, 2019
Closed
code-asher added a commit that referenced this pull request Jun 19, 2019
@code-asher
Update VS Code to 1.33.0 (#445)
da1aad9 
* Update VS Code to 1.33.0

* Fix slow file tree

* Fix WindowsService fill

* Provide `off` on event listeners

* Fix webview

* Fix double title bar and missing preferences on Mac

* Bump VS Code version in Travis config

* Fix black dialog text (again)

* Fix shared process not starting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scsmithr scsmithr scsmithr approved these changes

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@code-asher @nol166 @scsmithr