Use Ingress v1 from Kubernetes v1.19 in helm chart

[jlandowner]

Hi. I found you use old version of Ingress in helm chart.
Ingress became GA in Kubernetes v1.19.

Output after v1.19

# Source: code-server/templates/ingress.yaml
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: code-server
  labels:
    helm.sh/chart: code-server-1.0.3
    app.kubernetes.io/name: code-server
    app.kubernetes.io/instance: code-server
    app.kubernetes.io/version: "3.12.0"
    app.kubernetes.io/managed-by: Helm
spec:
  rules:
    - host: "code-server.example.loc"
      http:
        paths:
          - path: /
            backend:
              service:
                name: code-server
                port: 
                  number: 8080

[jsjoeio]

cc @kylecarbs @bpmct @jawnsy since I'm less familiar with this part of code-server

[codecov]

Codecov Report

Merging #4244 (5a36627) into main (c11d51e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4244   +/-   ##
=======================================
  Coverage   65.09%   65.09%           
=======================================
  Files          36       36           
  Lines        1882     1882           
  Branches      380      380           
=======================================
  Hits         1225     1225           
  Misses        559      559           
  Partials       98       98           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c11d51e...5a36627. Read the comment docs.

[bpmct]

This seems fine but am going to test with a cluster :)

Will add instructions here on how to spin up a cluster and try the helm chart :)

[jsjoeio]

Will add instructions here on how to spin up a cluster and try the helm chart :)

You rock! Thank you so much!

[bpmct]

Actually, our existing helm docs have lovely instructions on using the helm chart. Docker Desktop's built-in Kubernetes cluster or k3d is a good way to create a new local cluster.

I created a custom values.yaml to use Ingress:

ingress:
  enabled: true
  annotations:
   kubernetes.io/ingress.class: nginx
  hosts:
   - host: 127.0.0.1.nip.io
     paths:
        - /

# if you haven't already, add ingress to cluster (https://kubernetes.github.io/ingress-nginx/deploy/)

git clone https://github.com/jlandowner/code-server
cd code-server
helm upgrade --install code-server ci/helm-chart --values values.yaml

# worked without deprecation notices! 

# clean up
helm uninstall code-server
# if test cluster, delete/reset

Just approved but will defer to @Matthew-Beckett since they maintain the chart :)

[Matthew-Beckett]

@bpmct thanks Ben, will take a look!

[Matthew-Beckett]

Looks good to me! Thanks for your contribution ❤️

[bpmct]

@jsjoeio are we able to use CODEOWNERS or something so we can assign helm PRs to Matthew?

[jsjoeio]

@jsjoeio are we able to use CODEOWNERS or something so we can assign helm PRs to Matthew?

Great idea! Yes, I'll do that now.