Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package.json): update node version requirements to >=14 #4230

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

AbdullahBinJahed
Copy link
Contributor

@AbdullahBinJahed AbdullahBinJahed commented Sep 23, 2021

Fixes #4225

@AbdullahBinJahed AbdullahBinJahed requested a review from a team as a code owner September 23, 2021 17:38
@GirlBossRush GirlBossRush enabled auto-merge (rebase) September 23, 2021 19:13
@GirlBossRush GirlBossRush self-assigned this Sep 23, 2021
@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #4230 (b8dcafc) into main (ed09268) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4230   +/-   ##
=======================================
  Coverage   65.09%   65.09%           
=======================================
  Files          36       36           
  Lines        1882     1882           
  Branches      380      380           
=======================================
  Hits         1225     1225           
  Misses        559      559           
  Partials       98       98           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed09268...b8dcafc. Read the comment docs.

@jsjoeio jsjoeio changed the title node version 14 to node version 14 or greater in package.json fix(package.json): update node version requirements to >=14 Sep 23, 2021
@GirlBossRush GirlBossRush merged commit c11d51e into coder:main Sep 24, 2021
@AbdullahBinJahed
Copy link
Contributor Author

hey, why it's still not working ?

@jsjoeio
Copy link
Contributor

jsjoeio commented Sep 27, 2021

@AbdullahBinJahed this was merged, but it won't be available until we release 3.12.1

@AbdullahBinJahed
Copy link
Contributor Author

@AbdullahBinJahed this was merged, but it won't be available until we release 3.12.1

hmm yeah already noticed right after commenting here but still thanks for telling me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installing on Termux failed due to Node version
3 participants