fix(publish): update cdrci fork in brew-bump.sh #3468
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the homebrew
brew-bump.sh
step which runs when we publish a new release.Additional Context
Problem
When we publish a new release, we run a script to bump the formula for code-server on homebrew. The script works using
cdrci
's GitHub token (secret in repo) so that the PR comes from them and not a maintainer.The problem is
bump-formula-pr
uses the user'shomebrew-core
fork.This means we need to ensure the fork is up-to-date.
To do that, we need to pull the remote and push the changes to the fork before running
bump-formula-pr
.We tried to see if it would "just work" by pulling and pushing, but the push command asks for a username and password.
Solution
You can get around this with
--all
. We found this solution here.Changes
brew-bump.sh
Screenshots
Tested locally and this new approach should work.
Checklist
CHANGELOG.md
Fixes #3444