Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Pomerium #3424

Merged
merged 5 commits into from
May 24, 2021
Merged

docs: add Pomerium #3424

merged 5 commits into from
May 24, 2021

Conversation

desimone
Copy link
Contributor

RE: pomerium/pomerium#2223

Checklist

  • updated CHANGELOG.md

@desimone desimone requested a review from a team as a code owner May 20, 2021 00:23
@jsjoeio jsjoeio added the docs Documentation related label May 20, 2021
@jsjoeio jsjoeio added this to the 3.11.0 milestone May 20, 2021
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! 🙌

One minor issue with URL (I think)

docs/FAQ.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #3424 (75e495c) into main (c6d5da1) will not change coverage.
The diff coverage is n/a.

❗ Current head 75e495c differs from pull request most recent head a86c9af. Consider uploading reports for the commit a86c9af to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3424   +/-   ##
=======================================
  Coverage   59.21%   59.21%           
=======================================
  Files          35       35           
  Lines        1709     1709           
  Branches      379      379           
=======================================
  Hits         1012     1012           
  Misses        559      559           
  Partials      138      138           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6d5da1...a86c9af. Read the comment docs.

Co-authored-by: Joe Previte <jjprevite@gmail.com>
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks so much @desimone 👍🏼

@jsjoeio jsjoeio added the new contributor For PRs by first-time contributor label May 21, 2021
@repo-ranger
Copy link
Contributor

repo-ranger bot commented May 21, 2021

Thanks for making your first contribution! 🙂

@jsjoeio
Copy link
Contributor

jsjoeio commented May 21, 2021

If you want to update the CHANGELOG with your change under "New Version" > "Documentation", then we'll make sure to credit you in the Release Notes for this update. Not required though :)

@jsjoeio jsjoeio self-assigned this May 21, 2021
@jsjoeio jsjoeio modified the milestones: 3.10.2, 3.11.0 May 21, 2021
@jsjoeio jsjoeio changed the title Add Pomerium docs: add Pomerium May 24, 2021
@jsjoeio jsjoeio enabled auto-merge May 24, 2021 21:28
@jsjoeio jsjoeio mentioned this pull request May 24, 2021
1 task
@jsjoeio jsjoeio merged commit 5c42b7c into coder:main May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related new contributor For PRs by first-time contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants