-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Firefox not showing Jupyter file #5334
Comments
yeah this is happening with |
Can confirm that this bug doesn't occur on 4.4.0 But I dont get how it can only affect one browser. |
Is this a duplicate of #5335? Or are they somehow related? |
@jsjoeio |
Ah got it. Okay We'll investigate! |
No.
No, they are not. |
@mathematicalmichael hooray! that's great to hear. We really need to add some e2e tests for Jupyter. I'm going to add this to the next sprint. |
FYI |
@Emporea @mathematicalmichael Please test again with Most probably related to #5321. |
Hooray! Thank you @benz0li for testing and confirming! |
|
Wait. Its not. huh.. It opened one time, but had the same bug after that again. |
@Emporea Use Firefox to log into https://demo.jupyter.b-data.ch. If it does not work, it might be a problem with your Firefox settings or extensions. |
I removed the docker container and recreated it and now its working so far. I hope it stays that way, cause i did that already several times, so it seems inconsistent for me. But thanks for solving it in theory. |
It runs just smoothly [also in practice] at https://demo.jupyter.b-data.ch 😉. |
Sometimes its working. Sometimes not. |
@Emporea are you seeing the same results here? |
The demo is also not working. |
@Emporea It is a problem with your Firefox settings or extensions, then. |
Whatever. The inconsistency makes it super hard to understand and to describe. You probably think i am a noob. |
See also #4777 (comment) about private/incognito mode [and possibly opening a folder (File > Open Folder...) before opening a Jupyter notebook]. |
@Emporea not a noob! Just trying to help. Any other information you can share is helpful, otherwise I will try reproducing |
coder/code-server#5334 for more info
I have a containerized environment that launches in the cloud (free) via binder here: https://mybinder.org/v2/gh/ml-starter-packs/microservice-workshop/main?urlpath=vscode/ (Dockerfile). latest commit pins codeserver to 4.5.1, and I found
|
oh okay, so not related to sidenote: i love that you can reproduce the errors on your own thanks to binder... what an age we live in. thank you so much for looking into it! |
correct! @benz0li opened an issue upstream: eclipse/openvsx#497
right?! crazy! though props to you for giving me the binder link to be able to reproduce so easily 🙌🏼 |
4.5.1 still only works occasionally regarding the "jupyterlab notebook not rendering" It cant be my firefox alone. |
I'm on 4.5.1 on macOS and I cannot reproduce 😢 ScreenshotRelatedThis looks like the exact same issue upstream, right? Maybe worth dropping a comment on that. |
regarding the 503... i think this was a temporary microsoft server thing, because it came back up later that day iirc. |
The problem still persists for me. 4.4.0 has no issue in loading jupyter files. >4.4.0 (for examples latest) on the other hand doesn't load, or only very occasionally. |
Please test for yourself and tell me if you have the same problem. (firefox) https://4.4.0.emporea.net Password: coder |
Thanks for testing.
Once its working (for example after history cleanup) the file will also load on tab reloads, that's apparently true. But close test.ipynb and open it up, and it will fail to load once again. (test it please) |
Only the first time. When I close it [while it fails loading] and open it again it loads properly. |
Okey. Well I am not able to test under MacOS. I tested several Linux Distros and Windows. Might be working on MacOS, seems to be a weird bug anyway cause every other Browser than Firefox is doing a proper job at loading it. |
@Emporea I have tested with your deployment at https://4.5.1.emporea.net/ ℹ️ This has nothing to do with the client's operating system. |
This is our plan for this issue. |
Cannot reproduce bug with latest versionI tested this today and it worked as expected. Steps to Reproduce
ExpectedIt shows the Jupyter file and runs code. ActualIt shows the Jupyter file and runs code. ScreenshotSince VS Code (assumingely) tests this on their own, we decided not to add an e2e test for now. If we find out one of our patches introduces a bug or something breaks in the future, we will revisit adding a test. Closing this for now. |
how can i get the Dockerfile about the image registry.gitlab.b-data.ch/jupyterlab/python/base, another way , how put the code-server in jupyterlab, can you give me some help or url about this ? thank you |
@H4Njx My JupyterLab Python docker stack is publicly available. Repository: https://github.com/b-data/jupyterlab-python-docker-stack: Usage > Build image: cd base && docker build \
--build-arg PYTHON_VERSION=3.11.4 \
-t jupyterlab/python/base \
-f latest.Dockerfile .
Other JupyterLab docker stacks (which also include Python v3.11.4):
ℹ️ Dev Containers for use with Codespaces are a work in progress and will be available soon. |
thank you so much. |
Is there an existing issue for this?
OS/Web Information
code-server --version
: 4.5.0 (About shows 4.4.0)Steps to Reproduce
Expected
Should show cells and Html Rendering
Actual
Endless Loading
Logs
Firefox Console (other browsers do not show this)
Screenshot/Video
Firefox ( also tested with new installation / different machine / vm etc.):
Other Browsers I tested (Opera, Chrome, Vivaldi, in this screenshot Edge)
Does this issue happen in VS Code or GitHub Codespaces?
Are you accessing code-server over HTTPS?
Notes
No response
The text was updated successfully, but these errors were encountered: