Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate use of pkg to make single-binary server #39

Closed
sr229 opened this issue Mar 6, 2019 · 8 comments
Closed

Evaluate use of pkg to make single-binary server #39

sr229 opened this issue Mar 6, 2019 · 8 comments

Comments

@sr229
Copy link
Contributor

sr229 commented Mar 6, 2019

pkg is a application that compiles the project into a single executable, which we currently do, but pkg seems to be flexible as you can provide runtime version and such with the sacrifice of requiring some of the requires to be __dirname'd

[Zeit pkg repo]

@kylecarbs
Copy link
Member

We've attempted to use pkg. Using native modules is a large problem we've found, along with differentiating filesystems between inside and outside the binary.

Using nexe has been alright, but our usage requires a lot of jankiness. Optimally, we'll eventually create our own project to compile the binary.

We're able to provide the runtime version with nexe.

@sr229
Copy link
Contributor Author

sr229 commented Mar 7, 2019

have you tried to open this to Zeit's devs about the problem with native modules @kylecarbs?

@kylecarbs
Copy link
Member

Seems its an open feature request: vercel/pkg#329

@nhooyr nhooyr added the wontfix label Mar 8, 2019
@nhooyr nhooyr closed this as completed Mar 8, 2019
code-asher pushed a commit that referenced this issue Jun 19, 2019
* Add ripgrep, fill native fs functions, add ping endpoint

* Make show in folder redirect to the workspace
@walking-octopus
Copy link

The feature request has been fulfilled. Can anyone investigate if it's possible now?

@jsjoeio
Copy link
Contributor

jsjoeio commented Apr 26, 2022

I wasn't around when this was being evaluated. @walking-octopus what benefits do you see in us using pkg?

@walking-octopus
Copy link

I feel it could be smaller or more convenient than an existing archive. If this was found important enough to hack around the limitations the last time, why not try again?

@jsjoeio
Copy link
Contributor

jsjoeio commented Apr 26, 2022

Interesting! Smaller is definitely appealing. I don't know the full history around some of the hacks or limitations from the early years of the project.

@code-asher do you have any context? Is this worth considering?

@code-asher
Copy link
Member

code-asher commented Apr 27, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants