Skip to content

Commit

Permalink
fix: keep product.json file permissions in release
Browse files Browse the repository at this point in the history
When we added the change to modify the `package.json` version using `mv`
and `jq` we didn't account for lost file permissions.

This caused a bug only happening in CI.

This should fix it by giving it 755 via `chmod`.
  • Loading branch information
jsjoeio committed Dec 2, 2022
1 parent 130f52e commit 0f66360
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,8 @@ jobs:
echo "Updating version in lib/vscode/product.json"
tmp=$(mktemp)
jq '.codeServerVersion = "$VERSION"' release/lib/vscode/product.json > "$tmp" && mv "$tmp" release/lib/vscode/product.json
# Ensure it has the same permissions as before
chmod 755 release/lib/vscode/product.json
- name: Compress release package
run: tar -czf package.tar.gz release
Expand Down

0 comments on commit 0f66360

Please sign in to comment.