Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python unit tests for bf16 GEMM on PVC #217

Open
wants to merge 3 commits into
base: sycl-develop
Choose a base branch
from

Conversation

sommerlukas
Copy link
Collaborator

Extends the existing infrastructure for Python unit tests for GEMM to
also allow testing of PVC/SYCL backend. Adds a unit test to test GEMM
with bfloat16 datatype on PVC.

Adds more supported configurations for bfloat16 GEMM on PVC to
generator.py.

Also improves resource handling for temporary files in compiler.py and
fixes some issues from recent upstream changes.

Signed-off-by: Lukas Sommer lukas.sommer@codeplay.com

Copy link
Collaborator

@FMarno FMarno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've added a couple of small comments to consider though

python/cutlass/library_defaults.py Show resolved Hide resolved
python/cutlass/utils/check.py Outdated Show resolved Hide resolved
Extends the existing infrastructure for Python unit tests for GEMM to
also allow testing of PVC/SYCL backend. Adds a unit test to test GEMM
with bfloat16 datatype on PVC.

Adds more supported configurations for bfloat16 GEMM on PVC to
generator.py.

Also improves resource handling for temporary files in compiler.py and
fixes some issues from recent upstream changes.

Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
@sommerlukas sommerlukas force-pushed the python-gemm-unittests branch from 63b5640 to f655fb6 Compare February 14, 2025 17:25
@sommerlukas sommerlukas requested a review from FMarno February 14, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants