Skip to content
This repository was archived by the owner on Apr 13, 2025. It is now read-only.

Feat/esbuild #394

Merged
merged 6 commits into from
Dec 30, 2021
Merged

Feat/esbuild #394

merged 6 commits into from
Dec 30, 2021

Conversation

TimTechDev
Copy link
Contributor

@TimTechDev TimTechDev commented Dec 28, 2021

Replace webpack5 with esbuild

  • Improved compilation time
  • monaco-editor v0.31.1
  • esnext compatible
  • Update esbuild config to include a watch and rebuild option
  • Improved build script with easy to understand log outputs
  • New update process: You only need to specify your bundle once.

- Improved compilation time
- `monaco-editor` v0.31.1
- esnext compatible

    Tim

Signed-off-by: Tim_Tech_Dev <Tim_Tech_Dev@protonmail.com>
    Tim

Signed-off-by: Tim_Tech_Dev <Tim_Tech_Dev@protonmail.com>
- Add events npm module

    Tim

Signed-off-by: Tim_Tech_Dev <Tim_Tech_Dev@protonmail.com>
@TimTechDev
Copy link
Contributor Author

Will need to add a watch mode and maybe production build.

- Update esbuild config to include a watch and rebuild option
- Improved build script with easy to understand log outputs
- New update process: You only need to specify your bundle once.

    Tim

Signed-off-by: Tim_Tech_Dev <Tim_Tech_Dev@protonmail.com>
Signed-off-by: Tim_Tech_Dev <Tim_Tech_Dev@protonmail.com>
@TimTechDev TimTechDev marked this pull request as ready for review December 29, 2021 21:37
@hlxid hlxid self-requested a review December 30, 2021 09:16
- Add webpack configs from gitignore
- Remove unused monaco workers

    Tim

Signed-off-by: Tim_Tech_Dev <Tim_Tech_Dev@protonmail.com>
@TimTechDev TimTechDev requested a review from hlxid December 30, 2021 10:37
Copy link
Member

@hlxid hlxid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this

@hlxid hlxid merged commit 35e8698 into codeoverflow-org:main Dec 30, 2021
hlxid added a commit to hlxid/skates-bundles that referenced this pull request Dec 30, 2021
Adding skates-bundles to the nodecg-io build script is not needed any more as of codeoverflow-org/nodecg-io#394. The nodecg-io build script now checks which packages are added to the npm workspace to figure out which packages it needs to build.
Note: current installs will work just fine after pulling. Just make sure to overwrite the local changes of the build script with the updated version when pulling.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants