This repository was archived by the owner on Apr 13, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 26
Feat/esbuild #394
Merged
Merged
Feat/esbuild #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improved compilation time - `monaco-editor` v0.31.1 - esnext compatible Tim Signed-off-by: Tim_Tech_Dev <Tim_Tech_Dev@protonmail.com>
Tim Signed-off-by: Tim_Tech_Dev <Tim_Tech_Dev@protonmail.com>
- Add events npm module Tim Signed-off-by: Tim_Tech_Dev <Tim_Tech_Dev@protonmail.com>
Will need to add a watch mode and maybe production build. |
- Update esbuild config to include a watch and rebuild option - Improved build script with easy to understand log outputs - New update process: You only need to specify your bundle once. Tim Signed-off-by: Tim_Tech_Dev <Tim_Tech_Dev@protonmail.com>
Signed-off-by: Tim_Tech_Dev <Tim_Tech_Dev@protonmail.com>
hlxid
reviewed
Dec 30, 2021
- Add webpack configs from gitignore - Remove unused monaco workers Tim Signed-off-by: Tim_Tech_Dev <Tim_Tech_Dev@protonmail.com>
hlxid
approved these changes
Dec 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for this
hlxid
added a commit
to hlxid/skates-bundles
that referenced
this pull request
Dec 30, 2021
Adding skates-bundles to the nodecg-io build script is not needed any more as of codeoverflow-org/nodecg-io#394. The nodecg-io build script now checks which packages are added to the npm workspace to figure out which packages it needs to build. Note: current installs will work just fine after pulling. Just make sure to overwrite the local changes of the build script with the updated version when pulling.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
webpack5
withesbuild
monaco-editor
v0.31.1