This repository was archived by the owner on Apr 13, 2025. It is now read-only.
Simplify importing of core #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a `index.ts` to core that re-exports everything important. That way services and bundles can import everything they need by just doing this:
```typescript
import { ... } from "nodecg-io-core";
```
Previously bundle/service developers would need to know in which file is which class and provide the full path.
Everything obviously still can be imported by using the full path but if anything is moved this doesn't need fixing of the paths and therefore is prefered.
This is a follow up on #131 which simplified importing of services.
hlxid
added a commit
to codeoverflow-org/nodecg-io-docs
that referenced
this pull request
Jan 8, 2021
Documentation update for codeoverflow-org/nodecg-io#163
|
IMO this should also be changed for every package/subproject. |
|
You mean in packages that are using nodecg-io e.g. skates-bundles or your private bundles? Yeah would propably be better. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
index.tsto core that re-exports everything important. That way services and bundles can import everything they need by just doing this:Previously bundle/service developers would need to know in which file is which class and provide the full path.
Everything obviously still can be imported by using the full path but if anything is moved this doesn't need fixing of the paths and therefore is prefered.
This is a follow up on #131 which simplified importing of services.
Docs update PR: codeoverflow-org/nodecg-io-docs#42