Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: reuse github workflows #95

Merged
merged 2 commits into from
Sep 29, 2023
Merged

chore: reuse github workflows #95

merged 2 commits into from
Sep 29, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 7, 2023 •
edited
Loading

  • update workflow files
  • update devkit version

@kenjis kenjis added the github_actions Pull requests that update GitHub Actions code label Sep 7, 2023
This was referenced Sep 7, 2023
Closed
Merged
@kenjis kenjis force-pushed the reuse-ga-workflows branch from ef143b6 to 71f5f83 Compare September 7, 2023 06:15
@kenjis
Copy link
Member Author

kenjis commented Sep 7, 2023

To fix the following error, we need codeigniter4/devkit#113 to be released, and update the devkit version in composer.json.

PHPUnit / phpunit / PHP 7.4 - MySQLi - lowest (pull_request)

Run vendor/bin/phpunit --verbose --coverage-text --testsuite main
PHP Fatal error:  Trait 'Nexus\PHPUnit\Extension\Expeditable' not found in /home/runner/work/settings/settings/tests/_support/TestCase.php on line 11

Fatal error: Trait 'Nexus\PHPUnit\Extension\Expeditable' not found in /home/runner/work/settings/settings/tests/_support/TestCase.php on line 11
Error: Process completed with exit code 255.

https://github.com/codeigniter4/settings/actions/runs/6106116068/job/16570668120?pr=95

@MGatner
Copy link
Member

MGatner commented Sep 9, 2023

I'd like a final discussion on DevKit's Rector dependency but then are we ready for release?

@kenjis kenjis force-pushed the reuse-ga-workflows branch 2 times, most recently from e990cc3 to 99dca99 Compare September 12, 2023 06:11
@kenjis kenjis mentioned this pull request Sep 12, 2023
Closed
4 tasks
@kenjis kenjis requested a review from MGatner September 27, 2023 00:50
@kenjis
Copy link
Member Author

kenjis commented Sep 27, 2023

Updated the devkit version.

@kenjis kenjis merged commit a2b8722 into codeigniter4:develop Sep 29, 2023
32 checks passed
@kenjis kenjis deleted the reuse-ga-workflows branch September 29, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @MGatner