Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): Fixes a typo in the ClearSettings command that was stopping execution #123

Merged
merged 3 commits into from
Mar 9, 2024

Conversation

lonnieezell
Copy link
Member

When running spark settings:clear it was throwing an error because of a typo on the service it was calling.

Call to a member function flush() on null

at VENDORPATH/codeigniter4/settings/src/Commands/ClearSettings.php:20

This adds the required s to make it settings and allow the command to run.

@kenjis
Copy link
Member

kenjis commented Mar 9, 2024

Can you run composer cs-fix?

@lonnieezell
Copy link
Member Author

lonnieezell commented Mar 9, 2024

Can you run composer cs-fix?

Since none of those style errors are related to this PR should I update the baseline or go ahead and include them in this since this is a simple enough change it won't get lost amongst the noise?

Eh, I'll just fix it so they don't harass more in the future I guess.

Edit: and of course running cs-fix on my local machine didn't fix all of the errors /sigh

@lonnieezell
Copy link
Member Author

ok, ran composer update and that seemed to have fixed it.

Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Certainly the changes in style has nothing to do with this PR, so the PR should be separated as it should be.
However, if the commits are separated, I think it is acceptable.
The style changes and fix are both small changes.

@lonnieezell lonnieezell merged commit 29d0c0c into develop Mar 9, 2024
30 checks passed
@kenjis kenjis deleted the command-fix branch March 9, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants