-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add foundRows
option for MySQLi config
#8979
feat: add foundRows
option for MySQLi config
#8979
Conversation
Update: fixed the CS issue in the test file |
Looks good, by the way i see unit test in Database Live many skipped after connection to database. @kenjis I think better skipped in setUp? i can make PR later. |
Yes, it should be in the setUp() method. |
Also add an ignore in phpstan to ignore missing foundRows in BaseConnection
I have moved the DBDriver checks to setUp() but it would still make the connection to DB each time. Other suggested changes are applied |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Thanks everyone! |
caranya biar bsa debuging instalasi pada codelnigter gimana |
Description
Added a new database config
foundRows
for MySQLi. Enabling this adds the flagMYSQLI_CLIENT_FOUND_ROWS
when connecting to a MySQL database.The flag changes the behaviour of
affectedRows()
forUPDATE
orINSERT ... ON DUPLICATE KEY UPDATE
, where the number of rows updated to the same value will also be returned. By default, it only returns the number rows with a value changed.Checklist: