Refactor: Apply PHPStan rule "Short ternary operator is not allowed" to RouteCollection #7947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjis
reviewed
Sep 18, 2023
system/Router/RouteCollection.php
Outdated
| @@ -1699,7 +1700,9 @@ public function resetRoutes() | |||
| */ | |||
| protected function loadRoutesOptions(?string $verb = null): array | |||
| { | |||
| $verb = $verb ?: $this->getHTTPVerb(); | |||
| if (null === $verb || $verb === '') { | |||
There was a problem hiding this comment.
because $verb is a string we also need to validade if its empty string to replace the validation $verb = $verb ?: $this->getHTTPVerb(); unless we check like this:
if (! $verb) {
$verb = $this->getHTTPVerb();
}
what do you sugest?
There was a problem hiding this comment.
Then, what if '0'?
Probably we don't expect '0' for $verb.
I'm not sure what is correct. The question is just a question.
So if you believe you should check '', it is fine.
By the way, we do not use Yoda conditions.
There was a problem hiding this comment.
After another review of all uses of this method I think its reasonable to only validate the nullvalue.
I will fix the commit.
pjsde
force-pushed
the
refactor-routecollection-phpstan
branch
from
f6899f9
to
d736bcf
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply PHPStan rule "Short ternary operator is not allowed" to RouteCollection
Checklist: