Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use config(Cache::class) in CodeIgniter #7297

Merged
merged 6 commits into from
Feb 26, 2023
Merged

refactor: use config(Cache::class) in CodeIgniter #7297

merged 6 commits into from
Feb 26, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Feb 23, 2023 •
edited
Loading

Description

  • refactor CodeIgniter
  • improve test

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added refactor Pull requests that refactor code 4.4 labels Feb 23, 2023
@kenjis kenjis mentioned this pull request Feb 23, 2023
Merged
5 tasks
@mostafakhudair
Copy link
Contributor

CodeIgniter\CodeIgniter::display404errors() should be affected too

@kenjis
docs: add PHPDoc
7cc02e8
@kenjis
refactor: use config() instead of new keyword
2e80f83
@kenjis
test: change to something more realistic
a17a2a0 
A CodeIgniter instance handle one request.
Use page caching in the run() method, instead of forcing to call cachePage().
Do not register invalid routes with query string.
@kenjis
docs: fix PHPDoc types
08493fb
@kenjis
refactor: use config() in display404errors()
1dfa4fe
@kenjis kenjis force-pushed the refactor-CodeIgniter-check-cache branch from 9ee7b21 to 1dfa4fe Compare February 23, 2023 23:50
@kenjis
Copy link
Member Author

kenjis commented Feb 23, 2023

Updated :display404errors().

@kenjis
Copy link
Member Author

kenjis commented Feb 23, 2023

Please review.

@kenjis kenjis merged commit dd4e542 into codeigniter4:4.4 Feb 26, 2023
@kenjis kenjis deleted the refactor-CodeIgniter-check-cache branch February 26, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
4.4 refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @mostafakhudair @MGatner