Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect segment number in URI::getSegment() exception message #7267

Merged
merged 3 commits into from
Feb 23, 2023
Merged

fix: incorrect segment number in URI::getSegment() exception message #7267

merged 3 commits into from
Feb 23, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Feb 17, 2023 •
edited
Loading

Description
Supersedes #7249

  • fix incorrect segment number in URI::getSegment() exception message
  • throw an exception for an impossible segment number

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them 4.4 labels Feb 17, 2023
@kenjis kenjis merged commit 434d657 into codeigniter4:4.4 Feb 23, 2023
@kenjis kenjis deleted the fix-URI-getSegment-exception-message branch February 23, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
4.4 bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @michalsn