Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move preload.php #6936

Merged
merged 2 commits into from
Dec 4, 2022
Merged

chore: move preload.php #6936

merged 2 commits into from
Dec 4, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Dec 4, 2022 •
edited
Loading

Description
Follow-up #6088

codeigniter4/framework also should have this file.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis
chore: move preload.php
253d385 
codeigniter4/framework also should have this file.
@kenjis kenjis added the github_actions Pull requests that update Github_actions code label Dec 4, 2022
@samsonasik
Copy link
Member

If preload.php is on framework part, which in vendor/ location already, the documentation usage may need update:

CodeIgniter4/admin/starter/preload.php

Line 51 in 197e996

'include' => __DIR__ . '/vendor/codeigniter4/framework/system',

CodeIgniter4/admin/starter/preload.php

Line 19 in 197e996

* 1. Set preload::$paths.

Or probably better change to:

'include' => __DIR__ . '/system',

on inside framework

@kenjis
Copy link
Member Author

kenjis commented Dec 4, 2022 •
edited
Loading

Updated the comment.

The preload.php should be located in the project root folder.
Devs should customize it.

If it is only in appstarter,

  1. devs who do not use appstarter can't get it easily.
  2. when it is updated, devs can't update it easily.

samsonasik
samsonasik approved these changes Dec 4, 2022
View reviewed changes
Copy link
Member

@samsonasik samsonasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@samsonasik samsonasik merged commit 7b950bd into codeigniter4:develop Dec 4, 2022
@samsonasik
Copy link
Member

Thank you @kenjis

@kenjis kenjis deleted the fix-move-preload.php branch December 4, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @samsonasik