-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Response::download() causes TypeError #6361
Conversation
Should |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comments.
Hi, same problem here, just testedkenjis fix and works fine. |
TypeError CodeIgniter\CodeIgniter::displayPerformanceMetrics(): Argument #1 ($output) must be of type string, null given, called in .../CodeIgniter4/system/CodeIgniter.php on line 500
62d411e
to
6d9f786
Compare
Changed the implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Any ideas how this made it through tests to release? |
Description
Fixes #6358
How to Test
Checklist: