Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lang() causes Error on CLI #6209

Merged
merged 3 commits into from
Jul 1, 2022
Merged

fix: lang() causes Error on CLI #6209

merged 3 commits into from
Jul 1, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jun 30, 2022 •
edited
Loading

Description
Supersedes #6200

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

kenjis added 3 commits June 30, 2022 17:34
@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jun 30, 2022
MGatner
MGatner approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better inversion of dependencies.

@MGatner
Copy link
Member

MGatner commented Jun 30, 2022

Action failures appear to be a Coveralls issue. It also is apparent that we are submitting coverage for every database driver, which I'm not sure how Coveralls handles.

@kenjis kenjis merged commit 11e1faa into codeigniter4:develop Jul 1, 2022
@kenjis kenjis deleted the fix-lang-on-cli branch July 1, 2022 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @MGatner