Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not call header() if headers have already been sent #5680

Merged
merged 1 commit into from
Feb 12, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Feb 12, 2022

Description
Fixes #5679

Before:
Screenshot 2022-02-12 13 02 08

After:
Screenshot 2022-02-12 13 02 12

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Feb 12, 2022
@kenjis kenjis merged commit 90257e5 into codeigniter4:develop Feb 12, 2022
@kenjis kenjis deleted the fix-exceptionHandler-header branch February 12, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: CodeIgniter\Debug\Exceptions::exceptionHandler() sending header causes error if headers already sent
3 participants