Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: SPARKED #5649

Closed
wants to merge 3 commits into from
Closed

refactor: SPARKED #5649

wants to merge 3 commits into from

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Feb 3, 2022

Description
The current CLIRequest does not know whether it is Spark request or PHP CLI request.

  • add CLIRequest::isSparked()
  • spark command uses sparked CLIRequest
  • and we will not need the constant SPARKED that makes testing difficult

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Feb 3, 2022
@kenjis
Copy link
Member Author

kenjis commented Feb 3, 2022

I thought again, and changed my mind.
I'll take this down for now.

@kenjis kenjis closed this Feb 3, 2022
This was referenced Feb 3, 2022
Merged
Merged
@kenjis kenjis deleted the refactor-SPARKED branch August 27, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonnieezell lonnieezell lonnieezell approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @lonnieezell