Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: table alias is prefixed when LIKE clause #5361

Merged
merged 2 commits into from
Nov 22, 2021
Merged

fix: table alias is prefixed when LIKE clause #5361

merged 2 commits into from
Nov 22, 2021

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 20, 2021

Description
Fixes #5360

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer labels Nov 20, 2021
@MGatner
Copy link
Member

MGatner commented Nov 21, 2021 •
edited
Loading

I've had a strange bug with LIKE using fully-qualified field names. Do you think this would apply here? https://github.com/duke-bluesmith/bluesmith/blob/develop/app/Libraries/Notices.php#L107

@kenjis kenjis merged commit be1908f into codeigniter4:develop Nov 22, 2021
@kenjis kenjis deleted the fix-prefixed-alias-bug branch November 22, 2021 00:19
@kenjis
Copy link
Member Author

kenjis commented Nov 22, 2021

@MGatner If you got an invalid identifier like "db_""j"."name", it is because of this bug.

kenjis added a commit to kenjis/CodeIgniter4 that referenced this pull request Mar 6, 2022
@kenjis
refactor: revert unneeded workaround from codeigniter4#5361
7509003
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: table alias is prefixed when LIKE clause
2 participants
@kenjis @MGatner