Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debug] Add formatted query string to timeline. #5196

Merged
merged 3 commits into from
Oct 15, 2021
Merged

[Debug] Add formatted query string to timeline. #5196

merged 3 commits into from
Oct 15, 2021

Conversation

sfadschm
Copy link
Contributor

@sfadschm sfadschm commented Oct 11, 2021

This is an alternative to #5192 using the already implemented collapsible timeline features.
Open for comments.

Closes #5159.
Supersedes and closes #5192.

Checklist:

  • Securely signed commits
  • Conforms to style guide

Screenshot (updated):
Unbenannt

Possibly useful Implemented adjustments:
Remove all timing infos from 'query string' rows and use a colspan instead to make room for the query string.

Co-Authored-By: Daniel Tiringer <53534182+danielTiringer@users.noreply.github.com>
@sfadschm
Copy link
Contributor Author

sfadschm commented Oct 11, 2021

Sidenote: Maybe IS NULL and others should be added to the highlighting list (like in #5129).

Co-authored-by: John Paul E. Balandan, CPA <51850998+paulbalandan@users.noreply.github.com>
@kenjis
Copy link
Member

kenjis commented Oct 15, 2021

HTML escaping is missing.

$query = $db->query("SELECT '<s>' FROM dual");

Screenshot 2021-10-15 17 10 00

Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add HTML escaping?

@sfadschm
Copy link
Contributor Author

Good catch. I can add this, but I think this would rather fit into #5200 as it is a change to the formatting of query itself and this PR is only about copying the already formatted query string to the timeline.

@kenjis kenjis merged commit 87ffde8 into codeigniter4:develop Oct 15, 2021
@sfadschm sfadschm deleted the timeline-query-strings branch October 15, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev: Debug Toolbar should display queries on the timeline
3 participants