Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Mark duplicate queries #5185

Merged
merged 8 commits into from
Oct 9, 2021
Merged

Feature - Mark duplicate queries #5185

merged 8 commits into from
Oct 9, 2021

Conversation

danielTiringer
Copy link
Contributor

The intent of this pull request is to address #5161 - providing a number of unique queries in the summary, and mark the duplicates with an icon or a different background.

The background part is WIP.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Co-authored-by: Lonnie Ezell <lonnieje@gmail.com>
@danielTiringer
Copy link
Contributor Author

@lonnieezell , I was wondering about how to mark duplicates.
If I was to make a slim column all the way to the left, populate it with a red colored capital "D" when it's a duplicate, and on hover it would explain that "This query ran more than once", would that be in line with your original vision for this issue?

@lonnieezell
Copy link
Member

@danielTiringer Originally, I was thinking the background for the query would be slightly different, but I think this is a nice simple solution. If we find it doesn't stand out enough down the road, we can always modify how it's showing.

@danielTiringer
Copy link
Contributor Author

This is how it currently looks:
image
The first call of a query is not marked, only the consecutive ones. And when one hovers over the row marked with red, the title text shows in a small popup message.

@lonnieezell
Copy link
Member

lonnieezell commented Oct 8, 2021

I think that orange makes things too difficult to read. A simple grey that's just a few shades darker than the background (or lighter for the dark theme) would work I believe.

For the light theme, the gray from the CI welcome page would probably work well: F7F8F9

Actually looking at it again - there's a hover color in use already. What do you think about just using that color for this?

@danielTiringer
Copy link
Contributor Author

I think that orange makes things too difficult to read. A simple grey that's just a few shades darker than the background (or lighter for the dark theme) would work I believe.

For the light theme, the gray from the CI welcome page would probably work well: F7F8F9

Actually looking at it again - there's a hover color in use already. What do you think about just using that color for this?

The hover colors look good to me. Thanks for the recommendation, I'll go with those.

@lonnieezell lonnieezell merged commit 3d17c68 into codeigniter4:develop Oct 9, 2021
@danielTiringer danielTiringer deleted the feature-mark-duplicate-queries branch October 9, 2021 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants