-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature - Mark duplicate queries #5185
Feature - Mark duplicate queries #5185
Conversation
Co-authored-by: Lonnie Ezell <lonnieje@gmail.com>
@lonnieezell , I was wondering about how to mark duplicates. |
@danielTiringer Originally, I was thinking the background for the query would be slightly different, but I think this is a nice simple solution. If we find it doesn't stand out enough down the road, we can always modify how it's showing. |
I think that orange makes things too difficult to read. A simple grey that's just a few shades darker than the background (or lighter for the dark theme) would work I believe. For the light theme, the gray from the CI welcome page would probably work well: F7F8F9 Actually looking at it again - there's a hover color in use already. What do you think about just using that color for this? |
The hover colors look good to me. Thanks for the recommendation, I'll go with those. |
The intent of this pull request is to address #5161 - providing a number of unique queries in the summary, and mark the duplicates with an icon or a different background.
The background part is WIP.
Checklist: