Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple filters for a route and classname filter #5128

Merged
merged 5 commits into from
Oct 5, 2021

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 25, 2021

Description
Supersedes #5108

  • add multiple filters for a route (disabled by default)
  • add Config\Feature class for enabling multiple filters
  • add classname filter
  • fix doc comments

CI4 follows semantic versioning, so changes that break backward compatibility are not allowed without major version up.

The multiple filters feature breaks backward compatibility, because it uses new methods.
Therefore, it is disabled by default and users can enable it in the configuration class if they want to use it.

Users who want to use the new features will be able to set themselves up for disruptive changes.
Users of existing CI4 applications will be backward compatible through updates.

The code will be more complex, but I think it will be less complex than adding code that forces the API to handle values of different types (e.g. converting an array to CSV and set it to a string variable) on the condition that no API changes are made at all.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis mentioned this pull request Sep 25, 2021
5 tasks
@lonnieezell lonnieezell merged commit 3ce7a52 into codeigniter4:develop Oct 5, 2021
@kenjis kenjis deleted the add-multiple-filters branch October 5, 2021 03:56
@kenjis kenjis mentioned this pull request Jan 19, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants